Re: pgsql: libpq: Grease the protocol by default
Jacob Champion <jacob.champion@enterprisedb.com>
From: Jacob Champion <jacob.champion@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
pgsql-hackers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Date: 2026-02-24T01:05:45Z
Lists: pgsql-hackers
On Mon, Feb 23, 2026 at 4:45 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Jacob Champion <jacob.champion@enterprisedb.com> writes:
> > Something like the attached (tested only against 9.2 so far)? I would
> > plan to backpatch after feature freeze is lifted.
(er, should have been "release freeze", though we're clearly in no hurry)
> Also: I was initially baffled why you thought this needs
> back-patching, but I guess you have one eye on packagers like
> Debian who think they can make older versions use newer libpq.so.
Right.
> It'd be good to spell out that reasoning in the commit message.
Okay, will do.
> It's not obvious to me where the problem lies. I can replicate
> the failure by trying to use HEAD's psql to connect to a 9.2
> server, but adding -d "max_protocol_version=3.0" makes psql happy,
> so why not pg_dumpall?
Hmmm, looks like the -dump1.log output is actually from *before*
pg_upgrade actually runs:
https://github.com/PGBuildFarm/client-code/blob/28d7e945cc2a27fecdf4cc685782821ca504db5d/PGBuild/Modules/TestUpgradeXversion.pm#L514
So that will still need to be modified in the buildfarm client,
independently of my patch. (I reproduced the error with a bare
pg_upgrade invocation and didn't think to look closer; sorry for the
confusion.)
--Jacob
Commits
-
pg_upgrade: Use max_protocol_version=3.0 for older servers
- c47744ede01c 14.23 landed
- e726620d208e 15.18 landed
- a38ed212ff23 16.14 landed
- ad7fc3f1f83f 17.10 landed
- 1b2773179f31 18.4 landed
- a60a103386a1 19 (unreleased) landed
-
libpq: Grease the protocol by default
- 4966bd3ed95e 19 (unreleased) cited
-
libpq: Prepare for protocol grease during 19beta
- d8d7c5dc8f74 19 (unreleased) cited