Re: Few untranslated error messages in OAuth

Jacob Champion <jacob.champion@enterprisedb.com>

From: Jacob Champion <jacob.champion@enterprisedb.com>

To: Daniel Gustafsson <daniel@yesql.se>

Cc: Álvaro Herrera <alvherre@kurilemu.de>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-11-13T16:23:43Z

Lists: pgsql-hackers

On Thu, Nov 13, 2025 at 4:49 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> If so, should that be extended to oauth_json_set_error as well? (and possibly others?)

That should be covered already by nls.mk, unless I messed that up
too... I'll do a deeper dive.

Another way to fix this would be to wrap the assignment to errctx in a
macro that nls.mk can key off of, like oauth_json_set_error() does.
But I'm curious what Alvaro has in mind?

--Jacob

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

libpq: Align oauth_json_set_error() with other NLS patterns
- 7a15cff1f111 18.2 landed
- f7fbd02d32c4 19 (unreleased) landed
libpq-oauth: Don't translate internal errors
- aac25567fec1 18.2 landed
- 301a1dcf00c8 19 (unreleased) landed
libpq: Add missing OAuth translations
- 169ff4ca930b 18.2 landed
- ea3370b18ebe 19 (unreleased) landed