Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

Jacob Champion <jacob.champion@enterprisedb.com>

From: Jacob Champion <jacob.champion@enterprisedb.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Euler Taveira <euler.taveira@enterprisedb.com>, Daniel Gustafsson <daniel@yesql.se>

Date: 2025-02-28T20:40:13Z

Lists: pgsql-hackers

Attachments

since-v8.diff.txt (text/plain)
v9-0001-pgstat-report-in-earlier-with-STATE_STARTING.patch (application/octet-stream) patch v9-0001
v9-0002-Report-external-auth-calls-as-wait-events.patch (application/octet-stream) patch v9-0002
v9-0003-squash-Report-external-auth-calls-as-wait-events.patch (application/octet-stream) patch v9-0003

On Fri, Feb 14, 2025 at 5:34 PM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> (But it doesn't
> seem like we're going to agree on this for now; in the meantime I'll
> prepare a version of the patch that only calls
> pgstat_bestart_security() once.)

v9 removes the first call, and moves the second (now only) call up and
out of the if/else chain, just past client authentication. The SSL
pre-auth tests have been removed.

Thanks!
--Jacob

Commits

Fix race condition in TAP test 007_pre_auth
- e2080261cc8c 18.0 landed
Split pgstat_bestart() into three different routines
- c76db55c9085 18.0 landed
backport: Extend background_psql() to be able to start asynchronously
- 6af51bf05a6a 13.21 landed
- 7c07ab62aeb7 14.18 landed
- c0bc11aebb01 15.13 landed
- 6ab58d506bba 16.9 landed
- 49b6f4a02b23 17.5 landed
backport: Improve handling of empty query results in BackgroundPsql
- 3c562b58c20e 13.21 landed
- 3170aece14b8 14.18 landed
- f4b08ccb4ec8 15.13 landed
- fbfd38662f72 16.9 landed
- 31a242e90c88 17.5 landed
Improve handling of empty query results in BackgroundPsql::query()
- 70291a3c66ec 18.0 landed
Extend Cluster.pm's background_psql() to be able to start asynchronously
- ba08edb06545 18.0 landed
dblink: Replace WAIT_EVENT_EXTENSION with custom wait events
- c789f0f6cc5d 17.0 cited