Horton

Thread

Commits

  1. ldapurl is supported with simple bind

  1. Document use of ldapurl with LDAP simple bind

    Jacob Champion <jacob.champion@enterprisedb.com> — 2024-05-24T18:54:49Z

    Hi all,

Our documentation implies that the ldapurl setting in pg_hba is used
for search+bind mode only. It was pointed out to me recently that this
is not true, and if you're dealing with simple bind on a non-standard
scheme or port, then ldapurl makes the HBA easier to read:

    ... ldap ldapurl="ldaps://ldap.example.net:49151" ldapprefix="cn="
ldapsuffix=", dc=example, dc=net"

0001 tries to document this helpful behavior a little better, and 0002
pins it with a test. WDYT?

Thanks,
--Jacob

  2. Re: Document use of ldapurl with LDAP simple bind

    Peter Eisentraut <peter@eisentraut.org> — 2024-06-28T07:11:42Z

    On 24.05.24 20:54, Jacob Champion wrote:
> Our documentation implies that the ldapurl setting in pg_hba is used
> for search+bind mode only. It was pointed out to me recently that this
> is not true, and if you're dealing with simple bind on a non-standard
> scheme or port, then ldapurl makes the HBA easier to read:
> 
>      ... ldap ldapurl="ldaps://ldap.example.net:49151" ldapprefix="cn="
> ldapsuffix=", dc=example, dc=net"
> 
> 0001 tries to document this helpful behavior a little better, and 0002
> pins it with a test. WDYT?

Yes, this looks correct.  Since ldapurl is really just a shorthand that 
is expanded to various other parameters, it makes sense that it would 
work for simple bind as well.

hba.c has this error message:

"cannot use ldapbasedn, ldapbinddn, ldapbindpasswd, ldapsearchattribute, 
ldapsearchfilter, or ldapurl together with ldapprefix"

This appears to imply that specifying ldapurl is only applicable for 
search+bind.  Maybe that whole message should be simplified to something 
like

"configuration mixes arguments for simple bind and search+bind"

(The old wording also ignores that the error might arise via "ldapsuffix".)

  3. Re: Document use of ldapurl with LDAP simple bind

    Jacob Champion <jacob.champion@enterprisedb.com> — 2024-07-08T21:27:12Z

    On Fri, Jun 28, 2024 at 12:11 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> This appears to imply that specifying ldapurl is only applicable for
> search+bind.  Maybe that whole message should be simplified to something
> like
>
> "configuration mixes arguments for simple bind and search+bind"
>
> (The old wording also ignores that the error might arise via "ldapsuffix".)

I kept the imperative "cannot" and tried to match the terminology with
our documentation at [1]:

    cannot mix options for simple bind and search+bind modes

WDYT?

--Jacob

[1] https://www.postgresql.org/docs/17/auth-ldap.html

  4. Re: Document use of ldapurl with LDAP simple bind

    Peter Eisentraut <peter@eisentraut.org> — 2024-07-23T08:37:36Z

    On 08.07.24 23:27, Jacob Champion wrote:
> On Fri, Jun 28, 2024 at 12:11 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> This appears to imply that specifying ldapurl is only applicable for
>> search+bind.  Maybe that whole message should be simplified to something
>> like
>>
>> "configuration mixes arguments for simple bind and search+bind"
>>
>> (The old wording also ignores that the error might arise via "ldapsuffix".)
> 
> I kept the imperative "cannot" and tried to match the terminology with
> our documentation at [1]:
> 
>      cannot mix options for simple bind and search+bind modes

Committed.

(I suppose this could be considered a bug fix, but I don't feel an 
urgency to go backpatching this.  Let me know if there are different 
opinions.)

  5. Re: Document use of ldapurl with LDAP simple bind

    Jacob Champion <jacob.champion@enterprisedb.com> — 2024-07-23T13:31:14Z

    On Tue, Jul 23, 2024 at 1:37 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> Committed.

Thanks!

> (I suppose this could be considered a bug fix, but I don't feel an
> urgency to go backpatching this.  Let me know if there are different
> opinions.)

Certainly no urgency. The docs part of the patch also could be
backported alone, but I don't feel strongly either way.

--Jacob