Horton
Menu

Re: pg_plan_advice

Jacob Champion <jacob.champion@enterprisedb.com>

View thread
From: Jacob Champion <jacob.champion@enterprisedb.com>
To: Robert Haas <robertmhaas@gmail.com>, Jakub Wartak <jakub.wartak@enterprisedb.com>
Cc: Dian Fay <di@nmfay.com>, Matheus Alcantara <matheusssilv97@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-16T18:14:19Z
Lists: pgsql-hackers 
On Wed, Jan 14, 2026 at 2:23 PM Robert Haas <robertmhaas@gmail.com> wrote:
> With that fixed, plan_advice.advice =
> 'join_order(f/d1 (d1 d2))' produces this:

Nice! With v10, the next crash comes from pgpa_walker_would_advise()
(from a code branch that has its own copy of the "cannot determine RTI
for advice target" error, so I assume it's a similar issue?).

Reproducing query:

   SET pg_plan_advice.advice = 'gather( ( ( orders ) ) )';
   EXPLAIN (COSTS OFF, PLAN_ADVICE)
     SELECT o_year FROM (
       SELECT extract(year FROM o_orderdate) AS o_year FROM orders
   );

results in

    TRAP: failed Assert("child_target->ttype ==
PGPA_TARGET_IDENTIFIER"), File:
"../contrib/pg_plan_advice/pgpa_walker.c", Line: 679, PID: 451047

--

I'm going to change my fuzzing focus over to Jakub's TPC-H schema for
a bit, because it doesn't require the corpus to adapt to new
identifiers for each new query, and I can fuzz the interesting queries
he finds directly. :D

--Jacob

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_plan_advice: Fix another unique-semijoin bug.

  2. pg_plan_advice: Export feedback-related definitions.

  3. pg_plan_advice: Fix a bug when a subquery is pruned away entirely.

  4. pg_plan_advice: Add alternatives test to Makefile.

  5. pg_plan_advice: Handle non-repeatable TABLESAMPLE scans.

  6. pg_stash_advice: Allow stashed advice to be persisted to disk.

  7. Add pg_stash_advice contrib module.

  8. pg_plan_advice: Avoid assertion failure with partitionwise aggregate.

  9. pg_plan_advice: Invent DO_NOT_SCAN(relation_identifier).

  10. Add an alternative_plan_name field to PlannerInfo.

  11. pg_plan_advice: Refactor to invent pgpa_planner_info

  12. Respect disabled_nodes in fix_alternative_subplan.

  13. get_memoize_path: Don't exit quickly when PGS_NESTLOOP_PLAIN is unset.

  14. test_plan_advice: Set TAP test priority 50 in meson.build.

  15. pg_plan_advice: Avoid a crash under GEQO.

  16. Test pg_plan_advice using a new test_plan_advice module.

  17. pg_plan_advice: Always install pg_plan_advice.h, and in the right place

  18. pg_plan_advice: Fix failures to accept identifier keywords.

  19. Add pg_plan_advice contrib module.

  20. Allow extensions to mark an individual index as disabled.

  21. Replace get_relation_info_hook with build_simple_rel_hook.

  22. Store information about Append node consolidation in the final plan.

  23. Store information about elided nodes in the final plan.

  24. Store information about range-table flattening in the final plan.

  25. Pass cursorOptions to planner_setup_hook.

  26. Fix PGS_CONSIDER_NONPARTIAL interaction with Materialize nodes.

  27. Fix mistakes in commit 4020b370f214315b8c10430301898ac21658143f

  28. Allow for plugin control over path generation strategies.

  29. Update some comments for fasthash

  30. Allow passing a pointer to GetNamedDSMSegment()'s init callback.

  31. Don't reset the pathlist of partitioned joinrels.

  32. Treat number of disabled nodes in a path as a separate cost metric.