Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. libpq: Send users to the wiki during grease failures

  1. PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2025-12-10T01:16:11Z

    I want to make sure this doesn't take anyone by surprise: I'm planning
to get Jelte's "grease" patch into shape for a commit some time in
January.

    https://commitfest.postgresql.org/patch/6157/

If you're unfamiliar with the concept of greasing [1], one way to
think of it is that we're inverting Postel's Law: we will be very
liberal in what we send during connection, and then fail the
connection outright if a server doesn't reply with a
NegotiateProtocolVersion that points out our nonsense. This helps
build confidence that a future bump in our protocol defaults won't
cause operational failures due to buggy implementations (proxies,
bouncers, other servers).

The plan is to grease the minor version number and at least one
protocol extension during the 19 beta, then revert partway through (as
tracked by a mid-beta Open Item). Users who run into trouble during
beta can revert to the previous behavior by setting
max_protocol_version=3.0, ideally *after* they file a bug report for
the peer implementation. Documenting that, in a way that's effective
for both users and implementers, is something that still needs work
for the current patchset.

So, if anyone has objections to the overall idea, now is a great time
to say so. (Here is fine, but preferably also on the patch thread for
posterity.)

Thanks!
--Jacob

[1] https://datatracker.ietf.org/doc/draft-edm-protocol-greasing/

  2. Re: PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2026-02-23T20:00:49Z

    On Tue, Dec 9, 2025 at 5:16 PM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> I want to make sure this doesn't take anyone by surprise: I'm planning
> to get Jelte's "grease" patch into shape for a commit some time in
> January.

As of January 54th, this is committed.

I wanted to get people's thoughts on communication. As it stands now,
beta users will be directed towards our own documentation [1] when
they hit a grease failure. But personally, I'd like the landing page
to be on the wiki, for several reasons:

- It can be written in a more casual voice, and go into detail that
would be out of place in a docs note
- It's easier to change quickly in response to end user feedback, if
we receive any
- It can remain in place after the beta period ends

But having libpq link to a wiki page makes that page a vandalism
target. Can a wiki page be protected in a way that still lets
committers edit it? Is there a third option that works better than the
docs or the wiki?

--Jacob

[1] https://www.postgresql.org/docs/devel/libpq-connect.html#LIBPQ-CONNECT-MAX-PROTOCOL-VERSION

  3. Re: PSA: Planning to grease protocol connections during 19beta

    Tom Lane <tgl@sss.pgh.pa.us> — 2026-02-23T20:20:13Z

    Jacob Champion <jacob.champion@enterprisedb.com> writes:
> I wanted to get people's thoughts on communication. As it stands now,
> beta users will be directed towards our own documentation [1] when
> they hit a grease failure. But personally, I'd like the landing page
> to be on the wiki, for several reasons:

> - It can be written in a more casual voice, and go into detail that
> would be out of place in a docs note
> - It's easier to change quickly in response to end user feedback, if
> we receive any
> - It can remain in place after the beta period ends

> But having libpq link to a wiki page makes that page a vandalism
> target. Can a wiki page be protected in a way that still lets
> committers edit it? Is there a third option that works better than the
> docs or the wiki?

We have the ability to lock down a wiki page, but I believe that means
nobody can edit it until a wiki admin unlocks it.  That might be the
way to go here though.  I concur with your reasoning that the main
docs are a less-good place.

			regards, tom lane

  4. Re: PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2026-02-26T16:30:37Z

    On Mon, Feb 23, 2026 at 12:20 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> We have the ability to lock down a wiki page, but I believe that means
> nobody can edit it until a wiki admin unlocks it.  That might be the
> way to go here though.  I concur with your reasoning that the main
> docs are a less-good place.

Okay, sounds good. I've created
https://wiki.postgresql.org/wiki/Grease for now; I'll work on filling
it in. I think FAQ-style might work well for this format.

--Jacob

  5. Re: PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2026-04-13T18:58:20Z

    On Thu, Feb 26, 2026 at 8:30 AM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> Okay, sounds good. I've created
> https://wiki.postgresql.org/wiki/Grease for now; I'll work on filling
> it in. I think FAQ-style might work well for this format.

I worked on a rough draft last week, and it looks like it's now being
cached for anonymous users too:

    https://wiki.postgresql.org/wiki/Grease

I went for heavy editorializing and conversational style. One section
for users, another for devs.

Something I'm struggling with is whether (and how) to have people let
us know when they've hit this, so that we know that the campaign is
working. I have some language to that effect in the "What do I need to
do?" section, but I don't really know what list I should point to, if
any, nor what they should say so that they don't confuse the list
regulars. I'm considering removing that part of the call to action.

--Jacob

  6. Re: PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2026-05-05T21:27:21Z

    On Mon, Apr 13, 2026 at 11:58 AM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> Something I'm struggling with is whether (and how) to have people let
> us know when they've hit this, so that we know that the campaign is
> working. I have some language to that effect in the "What do I need to
> do?" section, but I don't really know what list I should point to, if
> any, nor what they should say so that they don't confuse the list
> regulars. I'm considering removing that part of the call to action.

I have removed this.

Are there any opinions on whether [1] in its current state is an
improvement over [2] as a landing page for users who hit this? I would
only swap out the link if I can get the wiki page protected.

Thanks,
--Jacob

[1] https://wiki.postgresql.org/wiki/Grease
[2] https://www.postgresql.org/docs/devel/libpq-connect.html#LIBPQ-CONNECT-MAX-PROTOCOL-VERSION

  7. Re: PSA: Planning to grease protocol connections during 19beta

    Jelte Fennema <postgres@jeltef.nl> — 2026-05-06T08:25:23Z

    On Tue, May 5, 2026, 23:27 Jacob Champion <jacob.champion@enterprisedb.com>
wrote:

> Are there any opinions on whether [1] in its current state is an
> improvement over [2] as a landing page for users who hit this? I would
> only swap out the link if I can get the wiki page protected.
>

I very much like the wiki page. Thanks for writing that. I would definitely
prefer that to be the landing page (assuming it can be locked down).

>

  8. Re: PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2026-05-06T15:05:53Z

    On Wed, May 6, 2026 at 1:25 AM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> I very much like the wiki page. Thanks for writing that.

Thank you for writing the feature!

> I would definitely prefer that to be the landing page (assuming it can be locked down).

Sounds good; I will ask around.

--Jacob

  9. Re: PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2026-05-29T18:49:34Z

    On Wed, May 6, 2026 at 8:05 AM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> > I would definitely prefer that to be the landing page (assuming it can be locked down).
>
> Sounds good; I will ask around.

Joe did this for us [1] -- thanks Joe! -- and I've pushed the commit
to link to it.

So: thanks everybody! Now we get to see if anything happens.

--Jacob

[1] https://postgr.es/m/72dd6202-3346-40b3-be3e-7ae22f914302%40joeconway.com

  10. Re: PSA: Planning to grease protocol connections during 19beta

    Jelte Fennema <postgres@jeltef.nl> — 2026-06-03T08:03:55Z

    On Mon, Apr 13, 2026, 20:58 Jacob Champion <jacob.champion@enterprisedb.com>
wrote:

> Something I'm struggling with is whether (and how) to have people let
> us know when they've hit this, so that we know that the campaign is
> working. I have some language to that effect in the "What do I need to
> do?" section, but I don't really know what list I should point to, if
> any, nor what they should say so that they don't confuse the list
> regulars. I'm considering removing that part of the call to action.
>

I think it'd be good if they notify us too. So we can get a sense of
whether it's "safe enough" to bump the protocol version at some point
and/or we can bug important offenders that we have some sway over. How
about adding something like this to the wiki page:

Please also report the issue to the pgsql-hackers mailinglist using the
[grease] tag at the start of the subject and include a link to the upstream
issue (if it's on a public issue tracker). As an example:

To: pgsql-hackers@lists.postgresql.org
Subject: [grease] ExampleProxy fails grease check
Body:
I'm using ExampleProxy and it's failing the grease check. I've reported the
issue upstream at https://example.com/issues/1234

  11. Re: PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2026-06-03T18:38:00Z

    On Wed, Jun 3, 2026 at 1:04 AM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> I think it'd be good if they notify us too. So we can get a sense of whether it's "safe enough" to bump the protocol version at some point and/or we can bug important offenders that we have some sway over. How about adding something like this to the wiki page:
>
> Please also report the issue to the pgsql-hackers mailinglist using the [grease] tag at the start of the subject and include a link to the upstream issue (if it's on a public issue tracker). As an example:
>
> To: pgsql-hackers@lists.postgresql.org
> Subject: [grease] ExampleProxy fails grease check
> Body:
> I'm using ExampleProxy and it's failing the grease check. I've reported the issue upstream at https://example.com/issues/1234

Thanks! Something like that seems reasonable to me, yeah.

Any objections here to making -hackers the landing point? I wouldn't
want to do that for a released feature, but for a beta-only thing, I
feel like the audience will be small enough to avoid accidentally
DoSing ourselves.

--Jacob

  12. Re: PSA: Planning to grease protocol connections during 19beta

    Jelte Fennema <postgres@jeltef.nl> — 2026-06-03T19:30:42Z

    On Wed, 3 Jun 2026 at 20:38, Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> Any objections here to making -hackers the landing point? I wouldn't
> want to do that for a released feature, but for a beta-only thing, I
> feel like the audience will be small enough to avoid accidentally
> DoSing ourselves.

If it becomes too noisy we can change the page to suggest people to
report it some other way Another option would be to dedicate a wiki
page to it, but wiki edit permissions are non-trivial to get these
days. I prefer making it easy for people to report issues to us,
unless it becomes an actual problem.

  13. Re: PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2026-06-04T15:16:20Z

    On Wed, Jun 3, 2026 at 12:30 PM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> If it becomes too noisy we can change the page to suggest people to
> report it some other way

Yep! Hearing no objections so far, I'll copy-edit a version of your
suggestion this morning and send it to the wiki admins.

Thanks!
--Jacob

  14. Re: PSA: Planning to grease protocol connections during 19beta

    Jacob Champion <jacob.champion@enterprisedb.com> — 2026-06-04T20:48:17Z

    On Thu, Jun 4, 2026 at 8:16 AM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> Yep! Hearing no objections so far, I'll copy-edit a version of your
> suggestion this morning and send it to the wiki admins.

Done. Thank you!

--Jacob