Re: pgsql: oauth: Add unit tests for multiplexer handling

Jacob Champion <jacob.champion@enterprisedb.com>

From: Jacob Champion <jacob.champion@enterprisedb.com>
To: Christoph Berg <myon@debian.org>
Cc: Jacob Champion <jchampion@postgresql.org>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org, "stefan@kaltenbrunner.cc" <stefan@kaltenbrunner.cc>
Date: 2025-08-26T20:10:43Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. oauth: Explicitly depend on -pthread

  2. oauth: Add unit tests for multiplexer handling

On Tue, Aug 26, 2025 at 12:48 PM Christoph Berg <myon@debian.org> wrote:
> This seems to require more linking on Debian bullseye:

Bleh. Thanks for the report; looks like none of the bullseye animals
in the farm are building with Curl yet.

(cc Stefan: guaibasaurus seems like it'd be a good candidate; would
you consider using --with-libcurl there?)

> 20:19:29 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -moutline-atomics -g -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC test-oauth-curl.o oauth-utils.o -L../../../src/port -L../../../src/common -L../../../src/common -lpgcommon_shlib -L../../../src/port -lpgport_shlib -L../../../src/interfaces/libpq -lpq -Wl,-z,relro -Wl,-z,now  -Wl,--as-needed   -lcurl -lm  -o oauth_tests
> 20:19:29 /usr/bin/ld: oauth-utils.o: undefined reference to symbol 'pthread_sigmask@@GLIBC_2.17'
> 20:19:29 /usr/bin/ld: /lib/aarch64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
> 20:19:29 collect2: error: ld returned 1 exit status

Okay. So I need to pull in PTHREAD_CFLAGS/LIBS as well...

--Jacob