Re: _CRT_glob stuff

Jacob Champion <jacob.champion@enterprisedb.com>

From: Jacob Champion <jacob.champion@enterprisedb.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-09-18T15:15:30Z
Lists: pgsql-hackers
On Thu, Sep 18, 2025 at 3:03 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> Here is some relevant documentation that suggests that this is the
> correct approach:
>
> https://github.com/mingw-w64/mingw-w64/blob/master/mingw-w64-headers/crt/_mingw.h.in#L476
>
> This also says that the default is 0 anyway, so it's not clear whether
> this is even useful anymore.  The commit that introduced this (commit
> b787c554c26) is from 2022, so it's not that long ago.  (It appears to be
> some old mingw vs. new mingw issue?)

So if MinGW already defines its own version of this symbol [1], how
does this work in practice? Would it actually do anything if we
assigned -1 instead?

--Jacob

[1] https://github.com/mingw-w64/mingw-w64/blob/8181947c/mingw-w64-crt/crt/wildcard.c



Commits

  1. Fix compiler warnings around _CRT_glob

  2. Inhibit mingw CRT's auto-globbing of command line arguments