Horton

Re: Add comments about fire_triggers argument in ri_triggers.c

surya poondla <suryapoondla4@gmail.com>

View thread View on postgr.es
From: surya poondla <suryapoondla4@gmail.com>
To: Yugo Nagata <nagata@sraoss.co.jp>
Cc: pgsql-hackers@postgresql.org
Date: 2026-01-29T00:56:19Z
Lists: pgsql-hackers 
Hi Yugo,

Your patch change looks good.

Yes Amit, I agree that SPI_execute_snapshot() comments do provide some
context on AFTER triggers, but I still feel the newly added comment
in ri_PerformCheck() gives additional context on why the fire_triggers is
set to false.

Regards,
Surya Poondla

Commits

  1. Add comment explaining fire_triggers=false in ri_PerformCheck()