Re: Showing applied extended statistics in explain Part 2
Tatsuro Yamada <yamatattsu@gmail.com>
From: Tatsuro Yamada <yamatattsu@gmail.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Tatsuro Yamada <tatsuro.yamada@ntt.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-06-28T11:16:03Z
Lists: pgsql-hackers
Attachments
- output.txt (text/plain)
- 0001-Add-a-new-option-STATS-to-Explain-command.patch (application/x-patch) patch 0001
- test.sql (application/octet-stream)
Hi Tomas and All,
Attached file is a new patch including:
6) Add stats option to explain command
7) The patch really needs some docs (partly)
>4) Add new node (resolve errors in cfbot and prepared statement)
I tried adding a new node in pathnode.h, but it doesn't work well.
So, it needs more time to implement it successfully because this is
the first time to add a new node in it.
> 8) Add regression test (stats_ext.sql)
Actually, I am not yet able to add new test cases to stats_ext.sql.
Instead, I created a simple test (test.sql) and have attached it.
Also, output.txt is the test result.
To add new test cases to stats_ext.sql,
I'd like to decide on a strategy for modifying it. In particular, there are
381 places where the check_estimated_rows function is used, so should I
include the same number of tests, or should we include the bare minimum
of tests that cover the code path? I think only the latter would be fine.
Any advice is appreciated. :-D
P.S.
I'm going to investigate how to use CI this weekend hopefully.
Regards,
Tatsuro Yamada