Horton

Thread

Commits

  1. Fix documentation comment for pg_md5_hash

  1. Fix the synopsis of pg_md5_hash

    Tatsuro Yamada <tatsuro.yamada@ntt.com> — 2024-03-14T06:02:04Z

    Hi,

The synopsis of pg_md5_hash() seems wrong such as:
    - s/int/bool/
    - "errstr" is missing
So, I created a patch to fix them.

src/common/md5_common.c
==================================================
*  SYNOPSIS      #include "md5.h"
*                int pg_md5_hash(const void *buff, size_t len, char *hexsum)
...
bool
pg_md5_hash(const void *buff, size_t len, char *hexsum, const char **errstr)
==================================================

Please find attached file.

Regards,
Tatsuro Yamada
NTT Open Source Software Center

  2. Re: Fix the synopsis of pg_md5_hash

    Daniel Gustafsson <daniel@yesql.se> — 2024-03-14T08:32:55Z

    > On 14 Mar 2024, at 07:02, Tatsuro Yamada <tatsuro.yamada@ntt.com> wrote:

> So, I created a patch to fix them.

Thanks, applied.

--
Daniel Gustafsson

  3. Re: Fix the synopsis of pg_md5_hash

    Michael Paquier <michael@paquier.xyz> — 2024-03-14T22:59:41Z

    On Thu, Mar 14, 2024 at 09:32:55AM +0100, Daniel Gustafsson wrote:
> On 14 Mar 2024, at 07:02, Tatsuro Yamada <tatsuro.yamada@ntt.com> wrote:
>> So, I created a patch to fix them.
> 
> Thanks, applied.

Oops.  Thanks.
--
Michael

  4. Re: Fix the synopsis of pg_md5_hash

    Tatsuro Yamada <yamatattsu@gmail.com> — 2024-03-14T23:38:52Z

    Hi, Daniel and Michael,

On Thu, Mar 14, 2024 at 09:32:55AM +0100, Daniel Gustafsson wrote:
> > On 14 Mar 2024, at 07:02, Tatsuro Yamada <tatsuro.yamada@ntt.com> wrote:
> >> So, I created a patch to fix them.
> >
> > Thanks, applied.
>
> Oops.  Thanks.
> --
> Michael
>

Thank you guys!

Regards,
Tatsuro Yamada
NTT Open Source Software Center