Re: Add test of pg_prewarm extenion
Julien Rouhaud <rjuju123@gmail.com>
From: Julien Rouhaud <rjuju123@gmail.com>
To: Dong Wook Lee <sh95119@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Justin Pryzby <pryzby@telsasoft.com>
Date: 2022-08-01T09:55:40Z
Lists: pgsql-hackers
On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee <sh95119@gmail.com> wrote: > > > Keep in mind also that the logfile accumulates over stops and > > restarts. As you've coded this test, you don't know which DB start > > emitted the matching line, so the test proves a lot less than it > > ought to. > > > > I wonder also about race conditions. On fast machines, or those > > with weird schedulers, the test script might reach slurp_file > > before autoprewarm has had a chance to emit the log entry you want. > > I have no idea how to deal with race conditions. > Does anybody know how to deal with this? Couldn't you use $node->wait_for_log() instead?
Commits
-
Add a regression test for contrib/pg_prewarm.
- 2865b4060a43 16.0 landed