Horton

Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode

Julien Rouhaud <rjuju123@gmail.com>

View thread
From: Julien Rouhaud <rjuju123@gmail.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>, Hans Buschmann <buschmann@nidsa.net>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-08-17T16:34:45Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Revert refactoring of hex code to src/common/

  2. Rework refactoring of hex and encoding routines

On Tue, Aug 17, 2021 at 11:26 PM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Tue, Aug 17, 2021 at 09:39:30AM -0400, Tom Lane wrote:
> > Michael Paquier <michael@paquier.xyz> writes:
> > > In short, I am planning to address this regression with the attached,
> > > for a combined revert of 0d70d30, 5c33ba5 and 92436a7.
> >
> > OK, but the commit message should explain why they're getting reverted.
>
> Uh, I don't see those commits, e.g.:
>
>         $ git diff 0d70d30
>         fatal: ambiguous argument '0d70d30': unknown revision or path not in the working tree.
>         Use '--' to separate paths from revisions, like this:
>         'git <command> [<revision>...] -- [<file>...]'
>
>         $ git diff 5c33ba5
>         fatal: ambiguous argument '5c33ba5': unknown revision or path not in the working tree.
>         Use '--' to separate paths from revisions, like this:
>         'git <command> [<revision>...] -- [<file>...]'
>
>         $ git diff 92436a7
>         fatal: ambiguous argument '92436a7': unknown revision or path not in the working tree.
>         Use '--' to separate paths from revisions, like this:
>         'git <command> [<revision>...] -- [<file>...]'

Same here.  I'm assuming that the real commits are the one mentioned
in the patch, which are c3826f8,  aef8948 and ccf4e27.