Re: Enhanced error message to include hint messages for redundant options error

Julien Rouhaud <rjuju123@gmail.com>

From: Julien Rouhaud <rjuju123@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-02T11:42:54Z
Lists: pgsql-hackers
Le dim. 2 mai 2021 à 18:31, vignesh C <vignesh21@gmail.com> a écrit :

> On Sun, May 2, 2021 at 4:27 AM Alvaro Herrera <alvherre@alvh.no-ip.org>
> wrote:
> >
> > On 2021-May-01, Bharath Rupireddy wrote:
> >
> > > IMO, it's not good to change the function API just for showing up
> > > parse_position (which is there for cosmetic reasons I feel) in an error
> > > which actually has the option name clearly mentioned in the error
> message.
> >
> > Why not?  We've done it before, I'm sure you can find examples in the
> > git log.  The function API is not that critical -- these functions are
> > mostly only called from ProcessUtility and friends.
>
> I feel it is better to include it wherever possible.
>

+1

>

Commits

  1. Improve reporting of "conflicting or redundant options" errors.

  2. Refactor function parse_subscription_options.