Horton

Non working timeout detection in logical worker

Julien Rouhaud <rjuju123@gmail.com>

View thread View on postgr.es
From: Julien Rouhaud <rjuju123@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Jehan Guillaume De Rorthais ioguix <ioguix@free.fr>
Date: 2019-10-17T18:00:15Z
Lists: pgsql-hackers

Attachments

Hello,

Jehan-Guillaume (in Cc) reported me today a problem with logical
replication, where in case of network issue the walsender is correctly
terminating at the given wal_sender_timeout but the logical worker
kept waiting indefinitely.

The issue is apparently a simple thinko, the timestamp of the last
received activity being unconditionally set at the beginning of the
main processing loop, making any reasonable timeout setting
ineffective.  Trivial patch to fix the problem attached.

Commits

  1. Fix timeout handling in logical replication worker