Horton

Re: reindexdb & clusterdb broken against pre-7.3 servers

Julien Rouhaud <rjuju123@gmail.com>

View thread View on postgr.es
From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, noah@leadboat.com
Date: 2019-05-06T15:31:17Z
Lists: pgsql-hackers

Attachments

On Mon, May 6, 2019 at 3:49 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Michael Paquier <michael@paquier.xyz> writes:
> > On Mon, May 06, 2019 at 08:32:44AM -0400, Andrew Dunstan wrote:
> >> Why do we even have code referring to pre-7.3 servers? Wouldn't it be
> >> simpler just to remove that code?
>
> > Even for pg_dump, we only support servers down to 8.0.  Let's nuke
> > this code.
>
> +1.  I think psql claims to support down to 7.4, but that's still not
> a precedent for trying to handle pre-7.3.  Also, the odds that we'd
> not break this code path again in future seem pretty bad.

WFM.  Updated patch attached, I also removed another similar chunk in
the same file while at it.

Commits

  1. Remove some code related to 7.3 and older servers from tools of src/bin/