Re: compute_query_id and pg_stat_statements

Julien Rouhaud <rjuju123@gmail.com>

From: Julien Rouhaud <rjuju123@gmail.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Fujii Masao <masao.fujii@oss.nttdata.com>, Pavel Stehule <pavel.stehule@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Magnus Hagander <magnus@hagander.net>, Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, Christoph Berg <myon@debian.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-22T04:35:05Z
Lists: pgsql-hackers
Le sam. 22 mai 2021 à 02:27, Bruce Momjian <bruce@momjian.us> a écrit :

> On Fri, May 21, 2021 at 02:19:13PM -0400, Andrew Dunstan wrote:
> >
> > On 5/16/21 11:13 PM, Bruce Momjian wrote:
> > > On Sun, May 16, 2021 at 08:39:33PM +0800, Julien Rouhaud wrote:
> > >> Le dim. 16 mai 2021 à 11:23, Alvaro Herrera <alvherre@alvh.no-ip.org>
> a écrit :
> > >>
> > >>     On 2021-May-15, Bruce Momjian wrote:
> > >>
> > >>     > On Sat, May 15, 2021 at 05:32:58PM -0400, Bruce Momjian wrote:
> > >>
> > >>     > > I also added Alvaro as an author of the compute_query_id item.
> > >>     >   --------------------------------------------------------------
> > >>     >
> > >>     > Based on the commit message, adding Alvaro was incorrect, so I
> will
> > >>     > revert this change.
> > >>
> > >>     Agreed.  My work on this one was janitorial.
> > >>
> > >>
> > >> Thanks a lot Alvaro and Bruce!
> > > We are going to get to the goal line, one way or the other!  ;-)
> >
> >
> >
> > I've discussed this with Alvaro. He's not planning to do anything more
> > regarding this and I think we can close the open item.
>
> Works for me.
>

works for me too.

>

Commits

  1. Allow compute_query_id to be set to 'auto' and make it default

  2. Move pg_stat_statements query jumbling to core.