Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

Julien Rouhaud <rjuju123@gmail.com>

From: Julien Rouhaud <rjuju123@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Bruce Momjian <bruce@momjian.us>, Robert Haas <robertmhaas@gmail.com>, Michael Paquier <michael@paquier.xyz>, torikoshia <torikoshia@oss.nttdata.com>, Atsushi Torikoshi <atorik@gmail.com>, Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Evgeny Efimkin <efimkin@yandex-team.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-03-02T03:43:31Z

Lists: pgsql-hackers

Attachments

v17-0003-Expose-query-identifier-in-verbose-explain.patch (text/x-patch) patch v17-0003
v17-0002-Expose-queryid-in-pg_stat_activity-and-log_line_.patch (text/x-patch) patch v17-0002
v17-0001-Move-pg_stat_statements-query-jumbling-to-core.patch (text/x-patch) patch v17-0001

On Wed, Jan 20, 2021 at 12:43 AM Julien Rouhaud <rjuju123@gmail.com> wrote:
>
> On Fri, Jan 8, 2021 at 1:07 AM Julien Rouhaud <rjuju123@gmail.com> wrote:
> >
> > v15 that fixes recent conflicts.
>
> Rebase only, thanks to the cfbot!  V16 attached.

Recent commit exposed that the explain_filter() doesn't filter
negative sign.  This can now be a problem with query identifiers in
explain output as they use the whole bigint range.  v17 attached fixes
that, also rebased against current HEAD.

Commits

Clarify description of pg_stat_statements columns
- b4deefc39b93 15.0 landed
- 3b57d5af7435 14.0 landed
Fix wording in description of pg_stat_statements.toplevel
- f9e6d00df029 14.0 landed
Mention that toplevel is part of pg_stat_statements key.
- 7531fcb1fcf5 14.0 landed
adjust query id feature to use pg_stat_activity.query_id
- 9660834dd8bf 14.0 landed
Take the statistics collector out of the loop for monitoring backends'
- b13c9686d084 8.2.0 cited