Re: Fix parallel vacuum buffer usage reporting

Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>

From: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>

To: Alena Rybakina <lena.ribackina@yandex.ru>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Masahiko Sawada <sawada.mshk@gmail.com>

Date: 2024-04-22T08:07:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix parallel vacuum buffer usage reporting.
- 5cd72cc0c501 17.0 landed
- f199436c1281 16.3 landed
- faba2f8f35df 15.7 landed
Use bump context for TID bitmaps stored by vacuum
- 8a1b31e6e596 17.0 cited

Attachments

v3-0003-Remove-declaration-of-Vacuum-block-usage-tracking.patch (application/octet-stream) patch v3-0003
v3-0001-Fix-parallel-vacuum-buffer-usage-reporting.patch (application/octet-stream) patch v3-0001
v3-0002-Remove-unused-tracking-of-vacuum-buffer-usage.patch (application/octet-stream) patch v3-0002

On Sat, Apr 20, 2024 at 2:00 PM Alena Rybakina <lena.ribackina@yandex.ru>
wrote:

> Hi, thank you for your work with this subject.
>
> While I was reviewing your code, I noticed that your patch conflicts with
> another patch [0] that been committed.
>
> [0]
> https://www.postgresql.org/message-id/flat/CA%2BhUKGJkOiOCa%2Bmag4BF%2BzHo7qo%3Do9CFheB8%3Dg6uT5TUm2gkvA%40mail.gmail.com
>

I've rebased the patch and also split the changes:
1: Use pgBufferUsage in Vacuum and Analyze block reporting
2: Stop tracking buffer usage in the now unused Vacuum{Hit,Miss,Dirty}
variables
3: Remove declarations of Vacuum{Hit,Miss,Dirty}