Horton

Thread

Commits

  1. Fix handling of expecteddir in pg_regress

  2. regress: allow to specify directory containing expected files, for ecpg

  1. Fix expecteddir argument in pg_regress

    Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> — 2024-03-11T08:23:16Z

    Hi all!

pg_regress accepts the expecteddir argument. However, it is never used
and outputdir is used instead to get the expected files paths.

This patch fixes this and uses the expecteddir argument as expected.

Regards,
Anthonin

  2. Re: Fix expecteddir argument in pg_regress

    Daniel Gustafsson <daniel@yesql.se> — 2024-03-14T10:45:52Z

    > On 11 Mar 2024, at 09:23, Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> wrote:

> pg_regress accepts the expecteddir argument. However, it is never used
> and outputdir is used instead to get the expected files paths.

Nice catch, c855872074b5bf44ecea033674d22fac831cfc31 added --expecteddir
support to pg_regress but only implemented it for the ECPG tests.  Will have
another look at this before applying with a backpatch to v16 where
--expecteddir was added.

--
Daniel Gustafsson

  3. Re: Fix expecteddir argument in pg_regress

    Daniel Gustafsson <daniel@yesql.se> — 2024-03-15T20:24:38Z

    > On 14 Mar 2024, at 11:45, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> On 11 Mar 2024, at 09:23, Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> wrote:
> 
>> pg_regress accepts the expecteddir argument. However, it is never used
>> and outputdir is used instead to get the expected files paths.
> 
> Nice catch, c855872074b5bf44ecea033674d22fac831cfc31 added --expecteddir
> support to pg_regress but only implemented it for the ECPG tests.  Will have
> another look at this before applying with a backpatch to v16 where
> --expecteddir was added.

Pushed and backpatched, thanks for the submission!

--
Daniel Gustafsson