Thread

Re: Suggestion to add --continue-client-on-abort option to pgbench

Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> — 2025-09-25T08:27:44Z

Hi,

The patch looks good, I've spotted some typos in the doc.

+        Allows clients to continue their run even if an SQL statement
fails due to
+        errors other than serialization or deadlock. Unlike
serialization and deadlock
+        failures, clients do not retry the same transactions but
start new transaction.

Should be "but start a new transaction.", although "proceed to the
next transaction." may be clearer here that ?

+       number of transactions that got a SQL error
+       (zero unless <option>--failures-detailed</option> is specified)

It seems like both "a SQL" and "an SQL" are used in the codebase and
doc, but this page only uses "an SQL", so using "an SQL" may be better
for consistency.

+   If an SQL command fails due to serialization or deadlock errors, the
+   client does not aborted, regardless of whether

Should be "the client does not abort."

Regards,
Anthonin Bonnefoy