Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement
Akshay Joshi <akshay.joshi@enterprisedb.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-10-16T08:17:53Z
Lists: pgsql-hackers
On Wed, Oct 15, 2025 at 10:55 PM Álvaro Herrera <alvherre@kurilemu.de> wrote: > Hello, > > I have reviewed this patch before and provided a number of comments that > have been addressed by Akshay (so I encourage you to list my name and > this address in a Reviewed-by trailer line in the commit message). One > thing I had not noticed is that while this function has a "pretty" flag, > it doesn't use it to pass anything to pg_get_expr_worker()'s prettyFlags > argument, and I think it should -- probably just > > prettyFlags = GET_PRETTY_FLAGS(pretty); > > same as pg_get_querydef() does. > Fixed and added 'Reviewed-by:' > > Thanks > > -- > Álvaro Herrera PostgreSQL Developer — > https://www.EnterpriseDB.com/ >