Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY

Mihail Nikalayeu <michail.nikolaev@gmail.com>

From: Michail Nikolaev <michail.nikolaev@gmail.com>

To: Michael Paquier <michael@paquier.xyz>, Noah Misch <noah@leadboat.com>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2024-08-16T10:22:00Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Replace flaky CIC/RI isolation tests with a TAP test
- e1c971945d62 19 (unreleased) landed
Disable recently added CIC/RI isolation tests
- 77038d6d0b49 19 (unreleased) landed
Fix infer_arbiter_index for partitioned tables
- 81f72115cf18 19 (unreleased) landed
Stabilize tests some more
- a4a0fa0c7587 19 (unreleased) landed
Put back alternative-output expected files
- be25c7767728 19 (unreleased) landed
Remove doc and code comments about ON CONFLICT deficiencies
- 758479213d57 19 (unreleased) landed
Avoid use of NOTICE to wait for snapshot invalidation
- 5dee7a603f66 19 (unreleased) landed
Fix ON CONFLICT with REINDEX CONCURRENTLY and partitions
- 90eae926abbb 19 (unreleased) landed
Fix ON CONFLICT ON CONSTRAINT during REINDEX CONCURRENTLY
- 2bc7e886fc1b 19 (unreleased) landed
Fix new test for CATCACHE_FORCE_RELEASE builds
- 9e8fa05d3412 19 (unreleased) landed
Improve test case stability
- 417ac9c1eeeb 19 (unreleased) landed
Fix infer_arbiter_index during concurrent index operations
- bc32a12e0db2 19 (unreleased) landed
Doc: cover index CONCURRENTLY causing errors in INSERT ... ON CONFLICT.
- 438ccd33a37a 13.23 landed
- faba2595d619 14.20 landed
- e1dd1f924e19 15.15 landed
- 4c2895629f6f 16.11 landed
- 46524d519a2d 18.1 landed
- 27f714b5dad7 17.7 landed
- 8b18ed6dfbb8 19 (unreleased) landed
Fix infer_arbiter_indexes() to not assume resultRelation is 1.
- 915de706d28c 17.0 cited
Revert temporal primary keys and foreign keys
- 8aee330af55d 17.0 cited

Attachments

v2-0001-specs-to-reproduce-issues-with-CREATE-INDEX-REIND.patch (text/x-patch) patch v2-0001

Hello, everyone.

I have updated the spec to reproduce the issue, now it includes cases with
both CREATE INDEX and REINDEX.

To run:
      make -C src/test/modules/injection_points/ check

Issue reproduced on empty index, but it may happen on index of any with the
same probability.
It is not critical, of course, but in production system indexes are
regularly rebuilt using REINDEX CONCURRENTLY as recommended in
documentation [1].
In most of the cases it is done using pg_repack as far as I know.

So, in these production systems, there is no guarantee what INSERT ON
CONFLICT DO NOTHING/UPDATE will not fail with a "duplicate key value
violates unique constraint" error.

Best regards,
Mikhail.

[1]: https://www.postgresql.org/docs/current/routine-reindex.html

>