Horton

Re: [PATCH] Re: Proposal to Enable/Disable Index using ALTER INDEX

Shayon Mukherjee <shayonj@gmail.com>

View thread
From: Shayon Mukherjee <shayonj@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Gurjeet Singh <gurjeet@singh.im>, David Rowley <dgrowleyml@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-04-07T20:47:56Z
Lists: pgsql-hackers

Attachments

On Mon, Apr 7, 2025 at 4:01 PM Sami Imseih <samimseih@gmail.com> wrote:

> Thanks for the update!
>
> The changes in v15 look good to me. The patch does need to be rebased,
> and I also think you should add a tab-complete for CREATE INDEX
>
>
> simseih@bcd07415af92 postgresql % git diff
> diff --git a/src/bin/psql/tab-complete.in.c
> b/src/bin/psql/tab-complete.in.c
> index 8e2eb50205e..f1853a68ccc 100644
> --- a/src/bin/psql/tab-complete.in.c
> +++ b/src/bin/psql/tab-complete.in.c
> @@ -3434,6 +3434,8 @@ match_previous_words(int pattern_id,
>                          !TailMatches("POLICY", MatchAny, MatchAny,
> MatchAny, MatchAny, MatchAny) &&
>                          !TailMatches("FOR", MatchAny, MatchAny, MatchAny))
>                 COMPLETE_WITH("(");
> +       else if (TailMatches("*)"))
> +               COMPLETE_WITH("VISIBLE", "INVISIBLE");
>
>         /* CREATE OR REPLACE */
>         else if (Matches("CREATE", "OR"))
>
> IMO, with the above in place, this patch is RFC.
>
>
>
Thank you Sami, really appreciate it!

Attached v16 with feedback and rebased.

Thanks
Shayon