Re: issue with synchronized_standby_slots

Shlok Kyal <shlok.kyal.oss@gmail.com>

From: Shlok Kyal <shlok.kyal.oss@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Fabrice Chapuis <fabrice636861@gmail.com>, Ashutosh Sharma <ashu.coek88@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, Alexander Kukushkin <cyberdemn@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-10-24T10:34:09Z

Lists: pgsql-hackers

Attachments

v9_REL_18-0001-Remove-the-validation-from-the-GUC-check-h.txt (text/plain)
v9_HEAD-0001-Remove-the-validation-from-the-GUC-check-hoo.patch (application/x-patch)
v9_REL_17-0001-Remove-the-validation-from-the-GUC-check-h.txt (text/plain)

On Fri, 24 Oct 2025 at 15:08, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Oct 24, 2025 at 1:24 PM Hayato Kuroda (Fujitsu)
> <kuroda.hayato@fujitsu.com> wrote:
> >
> > Dear Shlok,
> >
> > ```
> > -- Can set synchronized_standby_slots to a non-existent slot name.
> > ALTER SYSTEM SET synchronized_standby_slots='missing';
> > SELECT pg_reload_conf();
> >
> > -- Reset the GUC.
> > ALTER SYSTEM RESET synchronized_standby_slots;
> > SELECT pg_reload_conf();
> > ```
> >
> > pg_reload_conf() is called twice here but I'm not sure it is really needed.
> > ALTER SYSTEM itself can validate parameters via parse_and_validate_value(elevel=ERROR),
> > and pg_reload_conf() won't affect synchronously.
>
> I also think pg_reload_conf() won't be required here.
>
I agree that .pg_reload_conf() is not required. I have removed it in
the latest version of patches.

Thanks,
Shlok Kyal