Re: Documentation update of wal_retrieve_retry_interval to mention table sync worker
Shlok Kyal <shlok.kyal.oss@gmail.com>
From: Shlok Kyal <shlok.kyal.oss@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-13T09:13:34Z
Lists: pgsql-hackers
On Mon, 13 Jan 2025 at 12:33, vignesh C <vignesh21@gmail.com> wrote: > > On Mon, 6 Jan 2025 at 08:47, Peter Smith <smithpb2250@gmail.com> wrote: > > > > Hi Vignesh, > > > > Some review comments for your v2 patch. > > > > ====== > > doc/src/sgml/logical-replication.sgml > > > > AFAICT the only difference you made is changing: > > FROM "a special kind of apply process" > > TO "a special kind of table synchronization worker process". > > > > There is only ONE kind of tablesync process, so I think saying "a > > special kind of table synchronization worker process" seems > > misleading. I also thought maybe it is better to mention that this is > > PER table. > > > > SUGGESTION: > > ... a special table synchronization worker process per table. > > Thanks, the updated v3 version patch has the changes for the same. > Hi Vignesh, I reviewed the v3 patch. And it looks good to me. Thanks and Regards, Shlok Kyal
Commits
-
Doc: Update the interaction of tablesync with wal_retrieve_retry_interval.
- 4a0e7314f11e 18.0 landed