Re: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY

On Mon, 18 Nov 2024 at 19:19, vignesh C <vignesh21@gmail.com> wrote:
>
> On Mon, 18 Nov 2024 at 13:07, Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
> >
> > Thanks for providing the comments.
> >
> > On Sat, 16 Nov 2024 at 17:29, vignesh C <vignesh21@gmail.com> wrote:
> >
> > I have attached the updated version of the patch.
>
> Few comments:
> 1) We have the following check for cols validation and rf validation:
>     /*
>      * If we know everything is replicated and the column list is invalid
>      * for update and delete, there is no point to check for other
>      * publications.
>      */
>     if (pubdesc->pubactions.pubinsert && pubdesc->pubactions.pubupdate &&
>       pubdesc->pubactions.pubdelete && pubdesc->pubactions.pubtruncate &&
>       !pubdesc->cols_valid_for_update && !pubdesc->cols_valid_for_delete)
>       break;
>
> Should we do this for replident_valid_for_update and
> replident_valid_for_delete also?
>
Yes, we can add this check.

> 2) This variable is not required, there is a warning:
> publicationcmds.c: In function ‘replident_has_unpublished_gen_col’:
> publicationcmds.c:486:41: warning: unused variable ‘x’ [-Wunused-variable]
Fixed

I have fixed the comments and attached an updated patch.

Thanks and Regards,
Shlok Kyal