Re: How can end users know the cause of LR slot sync delays?

Shlok Kyal <shlok.kyal.oss@gmail.com>

From: Shlok Kyal <shlok.kyal.oss@gmail.com>

To: shveta malik <shveta.malik@gmail.com>

Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Ashutosh Sharma <ashu.coek88@gmail.com>

Date: 2025-11-27T05:38:00Z

Lists: pgsql-hackers

Attachments

v16-0001-Add-slotsync_skip_reason-to-pg_replication_slots.patch (application/octet-stream)

On Thu, 27 Nov 2025 at 10:42, shveta malik <shveta.malik@gmail.com> wrote:
>
> On Thu, Nov 27, 2025 at 9:25 AM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
> >
> > I have made some minor changes in documentation and comments. Attached
> > the updated patch.
> >
>
> 1)
> <literal>NULL</literal> if
>        slot synchronization is successful.
>
> We shall add 'It is' to maintain continuity as the previous sentence has it.
>
> 2)
> Related to previous patch: pgstat_report_replslotsync() currently has
> sanity check Assert(SlotIsLogical(slot));
> Instead, shall we have Assert(slot->synced)? It will implicitly ensure
> that the slot is logical, plus it is important to check that we are
> updating stats of synced slot only.
>
Hi Shveta,

I have addressed the comments and attached the updated patch.

Thanks,
Shlok Kyal