Re: speed up a logical replica setup

Shlok Kyal <shlok.kyal.oss@gmail.com>

From: Shlok Kyal <shlok.kyal.oss@gmail.com>

To: Euler Taveira <euler@eulerto.com>

Cc: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Fabrízio de Royes Mello <fabriziomello@gmail.com>, vignesh C <vignesh21@gmail.com>

Date: 2024-03-07T13:01:38Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_createsubscriber: Remove obsolete comment
- 71795d1cb41b 17.0 landed
- 1330843bb78e 18.0 landed
pg_createsubscriber: Fix an unpredictable recovery wait time.
- e5ba6a5ab62c 17.0 landed
- 03b08c8f5f3e 18.0 landed
Fix unstable test in 040_pg_createsubscriber.
- ae4e072bad5f 17.0 landed
- 9fd8b331dfe1 18.0 landed
Fix the testcase introduced in commit 81d20fbf7a.
- ae395f0f7edb 18.0 landed
- 14387ab06503 17.0 landed
Further weaken new pg_createsubscriber test on Windows.
- 55c309fc5b08 17.0 landed
- a1333ec048fb 18.0 landed
Temporarily(?) weaken new pg_createsubscriber test on Windows.
- 54508209178b 17.0 landed
Make pg_createsubscriber warn if publisher has two-phase commit enabled.
- 917754557cc0 17.0 landed
Make pg_createsubscriber more wary about quoting connection parameters.
- b3f5ccebd79d 17.0 landed
pg_createsubscriber: Remove failover replication slots on subscriber
- 81d20fbf7a03 17.0 landed
pg_createsubscriber: Remove replication slot check on primary
- b96391382626 17.0 landed
pg_createsubscriber: Only --recovery-timeout controls the end of recovery process
- 04c8634c0c4d 17.0 landed
pg_createsubscriber: creates a new logical replica from a standby server
- d44032d01463 17.0 landed
Add some const decorations
- 48018f1d8c12 17.0 landed
Add option force_initdb to PostgreSQL::Test::Cluster:init()
- ff9e1e764fcc 17.0 cited
Remove MSVC scripts
- 1301c80b2167 17.0 cited

Attachments

v27-0001-pg_createsubscriber-creates-a-new-logical-replic.patch (application/x-patch) patch v27-0001
v27-0002-Use-latest-replication-slot-position-as-replicat.patch (application/x-patch) patch v27-0002
v27-0003-port-replace-int-with-string.patch (application/x-patch) patch v27-0003
v27-0004-Add-additional-testcases.patch (application/x-patch) patch v27-0004

Hi,

> Thanks for the feedback. I'm attaching v26 that addresses most of your comments
> and some issues pointed by Vignesh [1].

I have created a top-up patch v27-0004. It contains additional test
cases for pg_createsubscriber.

Currently, two testcases (in v27-0004 patch) are failing. These
failures are related to running pg_createsubscriber on nodes in
cascade physical replication and are already reported in [1] and [2].
I think these cases should be fixed. Thoughts?

The idea of this patch is to keep track of testcases, so that any
future patch does not break any scenario which has already been worked
on. These testcases can be used to test in our development process,
but which test should actually be committed, can be discussed later.
Thought?

[1]: https://www.postgresql.org/message-id/CAHv8Rj+5mzK9Jt+7ECogJzfm5czvDCCd5jO1_rCx0bTEYpBE5g@mail.gmail.com
[2]: https://www.postgresql.org/message-id/CAA4eK1Kq8qWiBK1-ky%2BjkuJRedoWLh5%3DVOmd%2BYwh9L8PUxdq%2BQ%40mail.gmail.com



Thanks and regards,
Shlok Kyal