Re: Pgoutput not capturing the generated columns

Shlok Kyal <shlok.kyal.oss@gmail.com>

From: Shlok Kyal <shlok.kyal.oss@gmail.com>

To: Peter Smith <smithpb2250@gmail.com>

Cc: Shubham Khanna <khannashubham1197@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, vignesh C <vignesh21@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "euler@eulerto.com" <euler@eulerto.com>

Date: 2024-07-19T06:01:01Z

Lists: pgsql-hackers

Attachments

v20-0001-Enable-support-for-include_generated_columns-opt.patch (application/octet-stream) patch v20-0001
v20-0002-Support-replication-of-generated-column-during-i.patch (application/octet-stream) patch v20-0002
v20-0003-Fix-behaviour-for-Virtual-Generated-columns.patch (application/octet-stream) patch v20-0003
v20-0004-Improve-include-generated-column-option-handling.patch (application/octet-stream) patch v20-0004

On Thu, 18 Jul 2024 at 13:55, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi, here are some review comments for v19-0002
> ======
> src/test/subscription/t/004_sync.pl
>
> 1.
> This new test is not related to generated columns. IIRC, this is just
> some test that we discovered missing during review of this thread. As
> such, I think this change can be posted/patched separately from this
> thread.
>
I have removed the test for this thread.

I have also addressed the remaining comments for v19-0002 patch.
Please find the latest patches.

v20-0001 - not modified
v20-0002 - Addressed the comments
v20-0003 - Addressed the comments
v20-0004 - Not modified

Thanks and Regards,
Shlok Kyal

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Generated column replication.
- 6252b1eaf82b 18.0 landed
Rename pubgencols_type to pubgencols in pg_publication.
- 75eb9766ec20 18.0 landed
Doc: Fix column name in pg_publication catalog.
- 117f9f328e0f 18.0 landed
Fix buildfarm failure introduced by commit e65dbc9927.
- b35434b134b1 18.0 landed
Change publication's publish_generated_columns option type to enum.
- e65dbc9927fb 18.0 landed
Fix \dRp+ output when describing publications with a lower server version.
- 991974bb4888 18.0 landed
Replicate generated columns when 'publish_generated_columns' is set.
- 7054186c4ebe 18.0 landed
Doc: Update the behavior of generated columns in Logical Replication.
- 5b0c46ea0932 18.0 landed
Replicate generated columns when specified in the column list.
- 745217a051a9 18.0 landed
Doc: Generated columns are skipped for logical replication.
- 7a089f6e6a14 17.0 cited