Thread
Commits
-
Doc: Fix logical replication examples.
- ce6513e96a17 19 (unreleased) landed
- 0e8c6565513d 18.0 landed
-
Replicate generated columns when 'publish_generated_columns' is set.
- 7054186c4ebe 18.0 cited
-
Update Examples in Logical Replication Docs
Shlok Kyal <shlok.kyal.oss@gmail.com> — 2025-07-21T17:27:06Z
Hi, While going through the example for column lists [1] and row filters [2] in logical replication, I found that the output of "\dRp+" is not updated as per PostgreSQL 18. In PG 18, a new column "Generated columns' was added in "\dRp+" by commit [3], so I think we should update the docs to reflect the same. I have attached a patch with the changes. The changes apply to both the branches REL_18_STABLE and HEAD. [1]: https://www.postgresql.org/docs/current/logical-replication-col-lists.html [2]: https://www.postgresql.org/docs/current/logical-replication-row-filter.html [3]:https://github.com/postgres/postgres/commit/7054186c4ebe24e63254651e2ae9b36efae90d4e Thanks, Shlok Kyal
-
Re: Update Examples in Logical Replication Docs
Peter Smith <smithpb2250@gmail.com> — 2025-07-22T02:15:18Z
On Tue, Jul 22, 2025 at 3:27 AM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote: > > Hi, > > While going through the example for column lists [1] and row filters > [2] in logical replication, I found that the output of "\dRp+" is not > updated as per PostgreSQL 18. In PG 18, a new column "Generated > columns' was added in "\dRp+" by commit [3], so I think we should > update the docs to reflect the same. I have attached a patch with the > changes. > The changes apply to both the branches REL_18_STABLE and HEAD. > Good catch. The patch LGTM (by inspection only -- I did not try it). Note there is a typo in the commit message: /Defination/Definition/ ====== Kind Regards, Peter Smith. Fujitsu Australia
-
Re: Update Examples in Logical Replication Docs
Amit Kapila <amit.kapila16@gmail.com> — 2025-07-22T04:50:04Z
On Mon, Jul 21, 2025 at 10:57 PM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote: > > While going through the example for column lists [1] and row filters > [2] in logical replication, I found that the output of "\dRp+" is not > updated as per PostgreSQL 18. In PG 18, a new column "Generated > columns' was added in "\dRp+" by commit [3], so I think we should > update the docs to reflect the same. I have attached a patch with the > changes. > The changes apply to both the branches REL_18_STABLE and HEAD. > Thanks for the report and patch. I'll take care of it. -- With Regards, Amit Kapila.