Re: Review of patch renaming constraints
Nikhils <nikkhils@gmail.com>
From: Nikhil Sontakke <nikkhils@gmail.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Joshua Berkus <josh@agliodbs.com>, pgsql-hackers@postgresql.org
Date: 2012-01-20T03:38:33Z
Lists: pgsql-hackers
> > Make check passed. Patch has tests for rename constraint. > > > > Most normal uses of alter table ... rename constraint ... worked > normally. However, the patch does not deal correctly with constraints > which are not inherited, such as primary key constraints: > > That appears to be because creating a primary key constraint does not > set pg_constraint.conisonly correctly. This was introduced recently > with noninherited check constraints. > > > Umm, conisonly is set as false from primary key entries in pg_constraint. And primary keys are anyways not inherited. So why is the conisonly field interfering in rename? Seems quite orthogonal to me. Regards, Nikhils