Horton

Re: Shared buffer access rule violations?

P <apraveen@pivotal.io>

View thread View on postgr.es
From: Asim R P <apraveen@pivotal.io>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, David Kimura <dkimura@pivotal.io>
Date: 2018-08-09T00:59:04Z
Lists: pgsql-hackers 
On Tue, Aug 7, 2018 at 7:00 PM, Peter Geoghegan <pg@bowt.ie> wrote:
>
> I wonder if it would be a better idea to enable Valgrind's memcheck to
> mark buffers as read-only or read-write. We've considered doing
> something like that for years, but for whatever reason nobody followed
> through.

Basic question: how do you mark buffers as read-only using memcheck
tool?  Running installcheck with valgrind didn't uncover any errors:

valgrind --trace-children=yes pg_ctl -D datadir start
make installcheck-parallel

Asim & David

Commits

  1. Fix inadequate buffer locking in FSM and VM page re-initialization.