Horton

Re: GiST README typos

John Naylor <johncnaylorls@gmail.com>

View thread
From: John Naylor <johncnaylorls@gmail.com>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-06T02:59:50Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Cosmetic fixes in GiST README

On Wed, Nov 5, 2025 at 1:19 PM Paul A Jungwirth
<pj@illuminatedcomputing.com> wrote:
> Here are fixes to a few typos I found in the GiST README.

 the child might have migrated as a result of concurrent splits of the
-parent, gistFindCorrectParent() is used to find the parent page.
+parent, so gistFindCorrectParent() is used to find the parent page.

-buffer attached to them. When a tuple is inserted at the top, the descend down
+buffer attached to them. When a tuple is inserted at the top, the descent down

LGTM

 being empty. Whenever we find one, we acquire a lock on the parent and child
-page, re-check that the child page is still empty. Then, we remove the
+page, then re-check that the child page is still empty. Then, we remove the
 downlink and mark the child as deleted, and release the locks.

I still find this a bit awkward -- perhaps "and re-check"? The last
sentence could do with just the last "and" as well, I think, but
that's a style consideration and not a grammar fix.

-- 
John Naylor
Amazon Web Services