Horton

Re: GiST README typos

John Naylor <johncnaylorls@gmail.com>

View thread
From: John Naylor <johncnaylorls@gmail.com>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-06T09:38:31Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Cosmetic fixes in GiST README

On Thu, Nov 6, 2025 at 1:36 PM Paul A Jungwirth
<pj@illuminatedcomputing.com> wrote:
>
> On Wed, Nov 5, 2025 at 7:00 PM John Naylor <johncnaylorls@gmail.com> wrote:
> >
> >  being empty. Whenever we find one, we acquire a lock on the parent and child
> > -page, re-check that the child page is still empty. Then, we remove the
> > +page, then re-check that the child page is still empty. Then, we remove the
> >  downlink and mark the child as deleted, and release the locks.
> >
> > I still find this a bit awkward -- perhaps "and re-check"? The last
> > sentence could do with just the last "and" as well, I think, but
> > that's a style consideration and not a grammar fix.
>
> I nearly wrote it that way myself. It's nice that it avoids the double
> "then". So I agree, let's go with "and re-check".

Pushed that way, thanks!

-- 
John Naylor
Amazon Web Services