Re: BUG #19450: Where is checksum_block.inc.c after master install?
John Naylor <johncnaylorls@gmail.com>
From: John Naylor <johncnaylorls@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2026-04-06T02:57:40Z
Lists: pgsql-bugs
On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > src/include/Makefile knows what it's supposed to install out > of that subtree, and it thinks storage/*.h is sufficient. > I didn't check to see if the meson system has the same oversight. > > One could argue that the real bug is having put a .c file into > the include/ tree in the first place. Why was it done like that? > Couldn't it be a .h file? That was the way it was first coded. I thought of this way to avoid adding an exception to headerscheck. I can reverse that decision easily, but I may not get to it today. -- John Naylor Amazon Web Services
Commits
-
Use .h for the file containing the page checksum code fragment
- 8c3e22a8f8b9 19 (unreleased) landed