Horton

Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments

John Naylor <johncnaylorls@gmail.com>

View thread
From: John Naylor <johncnaylorls@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: solaimurugan vellaipandiyan <drsolaimurugan.v@gmail.com>, Aleksander Alekseev <aleksander@tigerdata.com>, Payal Singh <payals1@umbc.edu>, pgsql-hackers@lists.postgresql.org
Date: 2026-05-11T04:46:06Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. De-obfuscate the comment in tsrank.c's calc_rank_or().

On Mon, May 11, 2026 at 6:37 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Attached are a proposed v8 of the patch, plus two diff files showing
> the effects.  v7-0001.diff.nocfbot is what the v7 patch does with
> today's HEAD (it's the same as before).  The v8 patch makes all those
> changes and in addition makes the ones shown in v8-0001.diff.nocfbot.
> I think those are pretty much all improvements, except that it kind
> of messes up Martin Utesch's ASCII-art signatures in the geqo files.

Agreed, although this one now seems to use even more vertical space
that doesn't contain anything:

-/* Function works as follows:
+/*
+ * Function works as follows:
+ *
  *
  *
- * */
+ */


-- 
John Naylor
Amazon Web Services