Re: Batch TIDs lookup in ambulkdelete
John Naylor <johncnaylorls@gmail.com>
From: John Naylor <johncnaylorls@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-06-09T11:03:33Z
Lists: pgsql-hackers
On Sat, Jun 7, 2025 at 4:34 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > BTW I found that the constant 'maxblkno' in test_tidstore.sql actually > equals to InvalidBlockNumber, but not MaxBlockNumber. I think it > doesn't make sense that TidStore uses InvalidBlockNumber as the key. > The attached 0001 patch fixes it. I think we can fix it separately on > HEAD as well as back branches. I don't see a bug here, so I don't see the need for a backpatch -- the block numbers in the tests are just numbers, they don't refer to actual relations. I understand the desire to make it closer to reality, but it seems cosmetic. -- John Naylor Amazon Web Services