Re: BUG #19450: Where is checksum_block.inc.c after master install?
John Naylor <johncnaylorls@gmail.com>
From: John Naylor <johncnaylorls@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2026-04-07T08:56:51Z
Lists: pgsql-bugs
On Mon, Apr 6, 2026 at 10:07 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > John Naylor <johncnaylorls@gmail.com> writes: > > On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > >> One could argue that the real bug is having put a .c file into > >> the include/ tree in the first place. Why was it done like that? > >> Couldn't it be a .h file? > > > That was the way it was first coded. I thought of this way to avoid > > adding an exception to headerscheck. I can reverse that decision > > easily, but I may not get to it today. > > Ah, the good ol' law of conservation of cruft. But on the whole > I think naming it .h not .c is less crufty. Agreed that there's > no great urgency about changing it. Okay, done that way as of commit 8c3e22a8f. -- John Naylor Amazon Web Services
Commits
-
Use .h for the file containing the page checksum code fragment
- 8c3e22a8f8b9 19 (unreleased) landed