Re: cpluspluscheck vs ICU again

John Naylor <johncnaylorls@gmail.com>

From: John Naylor <johncnaylorls@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter@eisentraut.org>

Date: 2025-07-09T07:40:40Z

Lists: pgsql-hackers

On Mon, Jul 7, 2025 at 11:06 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> John Naylor <johncnaylorls@gmail.com> writes:
> > I see that now. If extensions follow the practice of including system
> > headers before Postgres headers, it should be fine. I've attached v2
> > which removes the useless #undef and drafts an explanatory commit
> > message.
>
> Works for me.

Pushed.

-- 
John Naylor
Amazon Web Services

Commits

Update ICU C++ API symbols
- 9560c1ec1c93 13.22 landed
- a4f891b96235 14.19 landed
- baacfb9e609c 15.14 landed
- aae9aad19d82 16.10 landed
- 21ae8fc5fd86 17.6 landed
- dd29262077e8 18.0 landed
- 90bfae9f93e7 19 (unreleased) landed
Hide ICU C++ APIs from pg_locale.h
- ed26c4e25a44 19 (unreleased) landed
Remove implicit cast from 'void *'
- 3e73d8735371 18.0 landed
- 9adb58a3ccb5 19 (unreleased) landed
Inline CRC computation for small fixed-length input on x86
- e2809e3a1015 18.0 cited