Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use C11 alignas instead of pg_attribute_aligned

  2. Compute CRC32C on ARM using the Crypto Extension where available

  1. vectorized CRC on ARM64

    John Naylor <johncnaylorls@gmail.com> — 2025-05-14T10:36:27Z

    We did something similar for x86 for v18, and here is some progress
towards Arm support.

0001: Like e2809e3a101 -- inline small constant inputs to compensate
for the fact that 0002 will do a runtime check even if the usual CRC
extension is targeted. There is a difference from x86, however: On Arm
we currently align on 8-byte boundaries before looping on 8-byte
chunks. That requirement would prevent loop unrolling. We could use
4-byte chunks to get around that, but it's not clear which way is
best. I've coded it so it's easy to try both ways.

0002: Like 3c6e8c12389 and in fact uses the same program to generate
the code, by specifying Neon instructions with the Arm "crypto"
extension instead. There are some interesting differences from x86
here as well:
- The upstream implementation chose to use inline assembly instead of
intrinsics for some reason. I initially thought that was a way to get
broader compiler support, but it turns out you still need to pass the
relevant flags to get the assembly to link.
- I only have Meson support for now, since I used MacOS on CI to test.
That OS and compiler combination apparently targets the CRC extension,
but the PMULL instruction runtime check uses Linux-only headers, I
believe, so previously I hacked the choose function to return true for
testing. The choose function in 0002 is untested in this form.
- On x86 it could be fairly costly to align on a cacheline boundary
before beginning the main loop so I elected to skip that for short-ish
inputs in PG18. On Arm the main loop uses 4 16-byte accumulators, so
the patch acts like upsteam and always aligns on 16-byte boundaries.

0003: An afterthought regarding the above-mentioned alignment, this is
an alternative preamble that might shave a couple cycles for 4-byte
aligned inputs, e.g. WAL.

--
John Naylor
Amazon Web Services

  2. Re: vectorized CRC on ARM64

    John Naylor <johncnaylorls@gmail.com> — 2026-05-05T11:56:37Z

    On Mon, Apr 6, 2026 at 9:38 AM John Naylor <johncnaylorls@gmail.com> wrote:
> and appropriate guards. The earlier use of __builtin_constant_p in the
> x86 case didn't happen to cause any failures on MSVC for some reason.
> That path needs a guard as well, but since that's backpatchable I
> handle it later. It's unlikely anyone passing special CFLAGS is using
> a non-mainstream compiler, but that's still a potential trap waiting
> for someone.

Done in 648818ba3.

-- 
John Naylor
Amazon Web Services