Horton

Re: implicit casts from void*

John Naylor <johncnaylorls@gmail.com>

View thread View on postgr.es
From: John Naylor <johncnaylorls@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-01T05:56:57Z
Lists: pgsql-hackers 
On Tue, Jul 1, 2025 at 10:36 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> John Naylor <johncnaylorls@gmail.com> writes:
> > I received on off-list report that commit e2809e3a101 causes an error
> > when building an extension written in C++, since $subject is in a
> > header file. The fix is simply to add an explicit cast, so I plan to
> > push the attached soon.
>
> Hmpfh.  No objection to your patch, but I wonder why
> "headerscheck --cplusplus" didn't find this?  Can we get it
> to do so?

Good question, and it turns out it catches it just fine, but you have
to configure with CPPFLAGS="-msse4.2" (or run the script on a Red Hat
9-ish system).

--
John Naylor
Amazon Web Services

Commits

  1. Update ICU C++ API symbols

  2. Hide ICU C++ APIs from pg_locale.h

  3. Remove implicit cast from 'void *'

  4. Inline CRC computation for small fixed-length input on x86