Horton

Re: BUG: test_ginpostinglist second itemptr check is a no-op due to copy-paste error

John Naylor <johncnaylorls@gmail.com>

View thread View on postgr.es
From: John Naylor <johncnaylorls@gmail.com>
To: Jianghua Yang <yjhjstz@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2026-03-24T10:30:14Z
Lists: pgsql-hackers 
On Tue, Mar 24, 2026 at 8:59 AM John Naylor <johncnaylorls@gmail.com> wrote:
>
> On Tue, Mar 24, 2026 at 8:45 AM Jianghua Yang <yjhjstz@gmail.com> wrote:
> >   The attached patch fixes the second check to compare orig_itemptrs[1]
> >   with decoded_itemptrs[1] and reports (blk, off) as the expected
> >   value in the error message.
>
> Seems right to me, thanks for the patch. I'll take care of this.

This is done. It seems unlikely that this test would need to be
changed in back branches, but I went ahead and backpatched it anyway
just in case.

--
John Naylor
Amazon Web Services

Commits

  1. Fix copy-paste error in test_ginpostinglist