Horton

Thread

Commits

  1. Fix typo and case in messages

  1. A typo in a messsage?

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2023-12-22T06:49:39Z

    I found the following message introduced by a recent commit.

> errdetail("The first unsummarized LSN is this range is %X/%X.",
	 
Shouldn't the "is" following "LSN" be "in"?


diff --git a/src/backend/backup/basebackup_incremental.c b/src/backend/backup/basebackup_incremental.c
index 42bbe564e2..22b861ce52 100644
--- a/src/backend/backup/basebackup_incremental.c
+++ b/src/backend/backup/basebackup_incremental.c
@@ -575,7 +575,7 @@ PrepareForIncrementalBackup(IncrementalBackupInfo *ib,
 								tle->tli,
 								LSN_FORMAT_ARGS(tli_start_lsn),
 								LSN_FORMAT_ARGS(tli_end_lsn)),
-						 errdetail("The first unsummarized LSN is this range is %X/%X.",
+						 errdetail("The first unsummarized LSN in this range is %X/%X.",
 								   LSN_FORMAT_ARGS(tli_missing_lsn))));
 		}
 

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  2. Re: A typo in a messsage?

    John Naylor <johncnaylorls@gmail.com> — 2023-12-23T00:35:22Z

    On Fri, Dec 22, 2023 at 1:50 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> I found the following message introduced by a recent commit.
>
> > errdetail("The first unsummarized LSN is this range is %X/%X.",
>
> Shouldn't the "is" following "LSN" be "in"?

I think you're right, will push.

  3. Re: A typo in a messsage?

    John Naylor <johncnaylorls@gmail.com> — 2023-12-27T06:34:50Z

    On Fri, Dec 22, 2023 at 1:50 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> I found the following message introduced by a recent commit.
>
> > errdetail("The first unsummarized LSN is this range is %X/%X.",
>
> Shouldn't the "is" following "LSN" be "in"?

Pushed.

  4. Re: A typo in a messsage?

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2023-12-31T09:36:34Z

    At Wed, 27 Dec 2023 13:34:50 +0700, John Naylor <johncnaylorls@gmail.com> wrote in 
> > Shouldn't the "is" following "LSN" be "in"?
> 
> Pushed.

At Wed, 27 Dec 2023 13:35:24 +0700, John Naylor <johncnaylorls@gmail.com> wrote in 
>> I think "crc" should be in all uppercase in general and a brief
>> grep'ing told me that it is almost always or consistently used in
>> uppercase in our tree.
> I pushed this also.

Thanks for pushing them!

regads.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center