Horton

Re: [PATCH] Refactor bytea_sortsupport(), take two

John Naylor <johncnaylorls@gmail.com>

View thread
From: John Naylor <johncnaylorls@gmail.com>
To: Aleksander Alekseev <aleksander@tigerdata.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-16T08:28:18Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Separate out bytea sort support from varlena.c

On Thu, Nov 27, 2025 at 7:45 PM Aleksander Alekseev
<aleksander@tigerdata.com> wrote:
> > "Short byteas will have terminating NUL bytes in the abbreviated
> > datum. Abbreviated comparison need not  make a distinction between
> > thse NUL bytes, and NUL bytes representing actual NULs in the
> > authoritative representation." [...]
> >
> > After that, the rest seems to flow better at a quick glance.
>
> Yes, it is much better now, thanks! Previously the comment was
> reasoning about NUL bytes as if normally bytea can't have them which
> IMO was confusing.

Pushed v7 with a few small adjustments, mostly for pgindent and the
new practice to prefer palloc_object().

-- 
John Naylor
Amazon Web Services