Re: Should "CRC" be in uppercase?

John Naylor <johncnaylorls@gmail.com>

From: John Naylor <johncnaylorls@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-12-27T06:35:24Z
Lists: pgsql-hackers
On Mon, Dec 25, 2023 at 12:51 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> A new function check_control_file() in pg_combinebackup.c has the
> following message.
>
> >                       pg_fatal("%s: crc is incorrect", controlpath);
>
> I think "crc" should be in all uppercase in general and a brief
> grep'ing told me that it is almost always or consistently used in
> uppercase in our tree.

I pushed this also.



Commits

  1. Fix typo and case in messages