Horton

Re: [PATCH] Transaction traceability - txid_status(bigint)

Simon Riggs <simon@2ndquadrant.com>

View thread View on postgr.es
From: Simon Riggs <simon@2ndquadrant.com>
To: Craig Ringer <craig@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Petr Jelinek <petr@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>, Jim Nasby <Jim.Nasby@bluetreble.com>, Álvaro Herrera <alvaro.herrera@2ndquadrant.com>
Date: 2017-03-22T07:13:32Z
Lists: pgsql-hackers 
On 22 March 2017 at 03:35, Craig Ringer <craig@2ndquadrant.com> wrote:
> On 22 March 2017 at 09:49, Craig Ringer <craig@2ndquadrant.com> wrote:
>
>>> Overall, though, I think that 0001 looks far better than any previous
>>> iteration.  It's simple.  It looks safe.  It seems unlikely to break
>>> anything that works now.  Woo hoo!
>>
>> Funny that this started with "hey, here's a simple, non-invasive
>> function for looking up the status of an arbitrary xid".
>
> Changes made per discussion.

This looks good to me also. Does what we need it to do.

I was a little worried by possible performance of new lock, but its
not intended to be run frequently, so its OK.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Add a txid_status function.

  2. Track the oldest XID that can be safely looked up in CLOG.