Re: [HACKERS] MERGE SQL Statement for PG11
Simon Riggs <simon@2ndquadrant.com>
From: Simon Riggs <simon@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-01-04T17:38:16Z
Lists: pgsql-hackers
On 4 January 2018 at 17:29, Robert Haas <robertmhaas@gmail.com> wrote: > On Sat, Dec 30, 2017 at 6:01 AM, Simon Riggs <simon@2ndquadrant.com> wrote: >> Patch uses mechanism as agreed previously with Peter G et al. on this thread. > > I'm not sure that an agreement was reached, or what the substance of > that agreement was. I refer to this... and confirm I have implemented option 3 On 3 November 2017 at 11:07, Stephen Frost <sfrost@snowman.net> wrote: > * Robert Haas (robertmhaas@gmail.com) wrote: >> On Fri, Nov 3, 2017 at 1:05 PM, Simon Riggs <simon@2ndquadrant.com> wrote: >> > We seem to have a few options for PG11 >> > >> > 1. Do nothing, we reject MERGE >> > >> > 2. Implement MERGE for unique index situations only, attempting to >> > avoid errors (Simon OP) >> > >> > 3. Implement MERGE, but without attempting to avoid concurrent ERRORs (Peter) >> > >> > 4. Implement MERGE, while attempting to avoid concurrent ERRORs in >> > cases where that is possible. >> > >> > Stephen, Robert, please say which option you now believe we should pick. >> >> I think Peter has made a good case for #3, so I lean toward that >> option. I think #4 is too much of a non-obvious behavior difference >> between the cases where we can avoid those errors and the cases where >> we can't, and I don't see where #2 can go in the future other than #4. > > Agreed. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Add support for MERGE SQL command
- 7103ebb7aae8 15.0 landed
-
Add API of sorts for transition table handling in trigger.c
- 3a46a45f6f00 15.0 landed
-
Revert MERGE patch
- 08ea7a2291db 11.0 cited
-
Fix several bugs related to ON CONFLICT's EXCLUDED pseudo relation.
- ad2278379244 9.6.0 cited