Horton

Re: Fix permissions check on pg_stat_get_wal_senders

Simon Riggs <simon@2ndquadrant.com>

View thread
From: Simon Riggs <simon@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Feike Steenbergen <feikesteenbergen@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-01-05T14:19:46Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Default monitoring roles

On 23 December 2017 at 10:56, Michael Paquier <michael.paquier@gmail.com> wrote:
> On Fri, Dec 22, 2017 at 07:49:34AM +0100, Feike Steenbergen wrote:
>> On 21 December 2017 at 14:11, Michael Paquier <michael.paquier@gmail.com> wrote:
>> > You mean a WAL receiver here, not a WAL sender.
>>
>> Fixed, thanks
>
> [nit]
>                 /*
>  -               * Only superusers can see details. Other users only get the pid value
> +                * Only superusers and members of pg_read_all_stats can see details.
> +                * Other users only get the pid value
>                  * to know whether it is a WAL receiver, but no details.
>                  */
>
> Incorrect comment format.
> [/nit]
>
> Committers run pgindent on each patch before committing anyway, and what
> you are proposing here looks good to me, so I am marking that as ready for
> committer. Simon, as the original committer of 25fff407, could you look
> at what is proposed here?

Yup, I got this.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services