Re: COPY FREEZE and PD_ALL_VISIBLE

Simon Riggs <simon@2ndquadrant.com>

From: Simon Riggs <simon@2ndQuadrant.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2015-10-23T00:59:25Z
Lists: pgsql-hackers
On 18 October 2015 at 17:23, Jeff Janes <jeff.janes@gmail.com> wrote:

> I'm planning on adding a todo item to have COPY FREEZE set
> PD_ALL_VISIBLE.  Or is there some reason this can't be done?
>
> Since the whole point of COPY FREEZE is to avoid needing to rewrite the
> entire table, it seems rather perverse that the first time the table is
> vacuumed, it needs to rewrite the entire table.
>

That's pretty darn weird. I remember measuring the benefit during testing.
I remember Jeff D was talking about removing that flag at that time, so
perhaps that's it.

Either way, my bug, my bad, thanks for the report.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Set PD_ALL_VISIBLE and visibility map bits in COPY FREEZE